[ 
https://issues.apache.org/jira/browse/THRIFT-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538883#comment-13538883
 ] 

Avi Flamholz commented on THRIFT-1797:
--------------------------------------

I made a new patch and uploaded it. Please take a look.

Going forward, I expect that I will probably be correcting some more
bugs/stylistic stuff in the Python runtime and compiler (we are using it at
my company). Is there a better way to commit stuff to the master branch in
future than submitting bug reports and waiting for someone to answer? Can I
request a code review from someone specific who works on the Python
codebase?

Avi



                
> Python implementation of TSimpleJSONProtocol 
> ---------------------------------------------
>
>                 Key: THRIFT-1797
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1797
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Python - Library
>    Affects Versions: 1.2
>         Environment: Ubuntu
>            Reporter: Avi Flamholz
>         Attachments: python_simple_json_protocol.patch, 
> python_simple_json_protocol.patch
>
>
> I've attached a patch with a Python implementation of TSimpleJSONProtocol. 
> This protocol is write-only like the Java implementation. It also fixes a bug 
> in TJSONProtocol where the context stack was not being popped correctly. This 
> bug triggered a number of errors in the serialization and deserialization of 
> Thrift structures to JSON.
> The patch also includes a test of TSimpleJSONProtocol. The test checks that 
> it returns sensible results, but does not check that the wire-format is 
> equivalent to the Java wire format.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to