[ 
https://issues.apache.org/jira/browse/THRIFT-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539756#comment-13539756
 ] 

Nathan Beyer commented on THRIFT-1766:
--------------------------------------

{quote}Roger Meier added a comment - 26/Dec/12 16:50
I think we should create a dedicated base type binary instead of adding such 
fields.
see http://thrift.apache.org/docs/types/{quote}

I agree, but it seems that ship has already sailed. The use of binary types as 
a string without encoding using the IDL's metadata is already in most of the 
libraries already - it seemed to be in Java, C++ and Python already. I created 
this issue and the patches, so that I could get Java and Ruby interop going. 
Any reason to prevent putting this into the Ruby library without a full 
protocol enhancement?

There was an issue about a full binary type, THRIFT-429, but that was closed as 
it was seemingly deemed "not necessary". Perhaps that issue should be reopened, 
or a new issue created for a protocol enhancement to get full binary support.
                
> [Ruby] Provide support for binary types
> ---------------------------------------
>
>                 Key: THRIFT-1766
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1766
>             Project: Thrift
>          Issue Type: Bug
>          Components: Ruby - Library
>    Affects Versions: 0.9
>            Reporter: Nathan Beyer
>         Attachments: THRIFT-1766-provide-support-for-binary-types.patch
>
>
> The Ruby library didn't provide explicit support for 'binary' types, which 
> sort of worked on Ruby 1.8.7 and with Thrift 0.8, but it doesn't work with 
> Ruby 1.9.3 and the encoding changes that were included with Thrift 0.9.
> This issue is intended to provide first class support for the 'binary' type.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to