[ 
https://issues.apache.org/jira/browse/THRIFT-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544381#comment-13544381
 ] 

Hudson commented on THRIFT-1815:
--------------------------------

Integrated in Thrift #599 (See [https://builds.apache.org/job/Thrift/599/])
    THRIFT-1815 Code generators line buffer output (Revision 
945537c1fc88ae27ac8231d423927fb7b40d10a6)

     Result = ABORTED
jensg : 
https://git-wip-us.apache.org/repos/asf?p=thrift.git&a=commit&h=945537c1fc88ae27ac8231d423927fb7b40d10a6
Files : 
* compiler/cpp/src/generate/t_rb_generator.cc
* compiler/cpp/src/generate/t_d_generator.cc
* compiler/cpp/src/generate/t_delphi_generator.cc
* compiler/cpp/src/generate/t_ocaml_generator.cc
* compiler/cpp/src/generate/t_cocoa_generator.cc
* compiler/cpp/src/generate/t_erl_generator.cc
* compiler/cpp/src/generate/t_javame_generator.cc
* compiler/cpp/src/generate/t_perl_generator.cc
* compiler/cpp/src/generate/t_c_glib_generator.cc
* compiler/cpp/src/generate/t_csharp_generator.cc
* compiler/cpp/src/generate/t_js_generator.cc
* compiler/cpp/src/generate/t_hs_generator.cc
* compiler/cpp/src/generate/t_as3_generator.cc
* compiler/cpp/src/generate/t_cpp_generator.cc
* compiler/cpp/src/generate/t_go_generator.cc
* compiler/cpp/src/generate/t_xsd_generator.cc
* compiler/cpp/src/generate/t_st_generator.cc
* compiler/cpp/src/generate/t_py_generator.cc
* compiler/cpp/src/generate/t_html_generator.cc
* compiler/cpp/src/generate/t_java_generator.cc
* compiler/cpp/src/generate/t_php_generator.cc

                
> Code generators line buffer output
> ----------------------------------
>
>                 Key: THRIFT-1815
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1815
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (General)
>    Affects Versions: 0.9
>            Reporter: Andrew Gaul
>              Labels: performance
>             Fix For: 1.0
>
>         Attachments: thrift-1815-compiler-line-buffering.patch
>
>
> This results in slow performance on FUSE- and network-based filesystems, 
> e.g., eCryptfs.  std::ostream << std::endl emits a newline and flushes 
> buffers to the kernel[1], yielding excessive system calls.  Instead, emit 
> "\n" which does the equivalent without the flush[2].  The attached patch 
> accomplishes this while minimizing code churn by removing "using namespace 
> std" and introducing a static variable endl.
> [1] http://www.cplusplus.com/reference/ios/endl/
> [2] 
> http://stackoverflow.com/questions/5492380/what-is-the-c-iostream-endl-fiasco

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to