[
https://issues.apache.org/jira/browse/THRIFT-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13552311#comment-13552311
]
Kamil Salas edited comment on THRIFT-1595 at 1/13/13 9:12 PM:
--------------------------------------------------------------
Hi! The patch contains a bit more code, than this issue's requested. I've
implemented a common CLI for Java TestClient and TestServer, based on the c++
version.
TestClient and TestServer support various protocols, transports and even ssl
connection. I've also added switching server-type in TestServer.
New test cases's been added, but I think that test.sh should be rewritten. For
example in Java, there is TFastFramedTransport which is another implementation
of FramedTransport, but test.sh doesn't support this schema. We test also only
one server_type for every language in test.sh.
Test.sh shows that there are some bugs, but I hope it's not my fault :-)
Any comments are welcome!
was (Author: keppetto):
Hi! The patch contains a bit more code, then this issue's requested. I've
implemented a common CLI for Java TestClient and TestServer, based on the c++
version.
TestClient and TestServer support various protocols, transports and even ssl
connection. I've also added switching server-type in TestServer.
New test cases's been added, but I think that test.sh should be rewritten. For
example in Java, there is TFastFramedTransport which is another implementation
of FramedTransport, but test.sh doesn't support this schema. We test also only
one server_type for every language in test.sh.
Test.sh shows that there are some bugs, but I hope it's not my fault :-)
Any comments are welcome!
> Java test server should follow the documented behavior as of THRIFT-1590
> ------------------------------------------------------------------------
>
> Key: THRIFT-1595
> URL: https://issues.apache.org/jira/browse/THRIFT-1595
> Project: Thrift
> Issue Type: Sub-task
> Components: Test Suite
> Affects Versions: 0.9
> Reporter: Nathaniel Cook
> Assignee: Kamil Salas
> Labels: java, server, test
> Fix For: 1.0
>
> Attachments:
> 0002-Thrift-1595-Java-test-server-should-follow-the-docum.patch, out_test_sh
>
>
> The implementation of the java test server should be the same as the
> languages so our cross platform tests can work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
