[
https://issues.apache.org/jira/browse/THRIFT-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564278#comment-13564278
]
Chao Shi commented on THRIFT-1816:
----------------------------------
Roger, sorry for the late reply.
I found the difficult to add a included file to ThriftTest.thrift is that, all
language tests share the same file. I had to update MakeFile for these
languages, which I may not have a dev environment (e.g. c#). I'm not familiar
with these languages either.
Given that my patch is simply one line change, it seems a much large effort to
add such test. Do you think it OK to submit without the test?
> Need "require" included thrift files in "xxx_types.js"
> ------------------------------------------------------
>
> Key: THRIFT-1816
> URL: https://issues.apache.org/jira/browse/THRIFT-1816
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Compiler
> Reporter: Chao Shi
> Attachments: thrift-1816.patch
>
>
> Currently the compiler for nodejs only generate require statement in each
> service js. It is also needed in the "types" js. I have a patch for this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
