[
https://issues.apache.org/jira/browse/THRIFT-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13565525#comment-13565525
]
Nate Rosenblum commented on THRIFT-1846:
----------------------------------------
Well, I build on OSX & IOS as well, so all in all THRIFT 1740 is a net positive
:)
I did not look carefully at the changes involving socket.h in that patch,
sorry. The .cpp file includes Android's weird un.h before pulling in TSocket.h,
which is why the build is broken. If you want, I can push a new patch that
moves un.h into the header. LMK
> Restore socket.h header to support builds with Android NDK
> ----------------------------------------------------------
>
> Key: THRIFT-1846
> URL: https://issues.apache.org/jira/browse/THRIFT-1846
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9
> Environment: Building with Android Linux NDK R8D (and, it looks like,
> all previous NDKs)
> Reporter: Nate Rosenblum
> Fix For: 0.9
>
> Attachments:
> 0001-Restore-socket.h-include-to-support-Android-builds.patch
>
>
> Unlike every other rational un.h that I've seen, the sys/un.h (actually
> linux/un.h) distributed with the Android NDK doesn't define sa_family_t or
> include another header that does. Removal of socket.h in THRIFT-1740 broke
> the Android build.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
