[
https://issues.apache.org/jira/browse/THRIFT-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13612366#comment-13612366
]
Jake Farrell commented on THRIFT-1357:
--------------------------------------
I would say we remove jsx dependency and make it a contrib/lib/erlang addition.
We should try and keep as many dependencies out of the core libraries as
possible and if there are cases like this where an addition to a library
depends on a non apache available dependency (like as3crypto lib in maven for
as3 or jsx on github for erlang) then people are free to use them from the
contrib area if they want thus allowing for the jenkins builds to not be
broken. We also need to make sure to track the licensing on these type of
additions and update NOTICE and LICENSE files accordingly for these third party
libraries
> Erlang Dependency breaks build
> ------------------------------
>
> Key: THRIFT-1357
> URL: https://issues.apache.org/jira/browse/THRIFT-1357
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
> Environment: Apache build Infrastructure based on Ubuntu lucid
> {noformat}
> ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP virtual machine and base applicat
> ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP cryprographic modules
> ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP development libraries and headers
> ii erlang-eunit 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP module for unit testing
> ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP modules for handling abstract Erl
> ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP virtual machine and base applicat
> ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP cryprographic modules
> ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP development libraries and headers
> ii erlang-eunit 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP module for unit testing
> ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP modules for handling abstract Erl
> {noformat}
> Reporter: Roger Meier
> Assignee: Jake Farrell
> Attachments:
> 0001-Fixed-thrift_json_protocol.erl-to-work-with-JSX-v0.9.patch,
> 0001-updated-JSX-version.patch
>
>
> THRIFT-1227 introduced JSON for erlang,
> however the Ubuntu build infrastructur does not support this...
> {noformat}
> ./rebar get-deps
> ==> erl (get-deps)
> Pulling jsx from {git,"git://github.com/talentdeficit/jsx.git",{tag,"v0.9.0"}}
> Initialized empty Git repository in
> /home/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/erl/deps/jsx/.git/
> ==> nicefloats (get-deps)
> ==> jsx (get-deps)
> ./rebar compile
> ==> nicefloats (compile)
> Compiled src/nicefloats.erl
> ==> jsx (compile)
> ./include/jsx_common.hrl:34: type jsx_opt() undefined
> ./include/jsx_common.hrl:66: type jsx_parser_result() undefined
> ./include/jsx_common.hrl:82: type eep0018_array() undefined
> ./include/jsx_common.hrl:82: type eep0018_object() undefined
> ./include/jsx_common.hrl:84: type eep0018_term() undefined
> ./include/jsx_common.hrl:85: type eep0018_key() undefined
> ./include/jsx_common.hrl:85: type eep0018_term() undefined
> ./include/jsx_common.hrl:91: type eep0018_string() undefined
> ./include/jsx_common.hrl:92: type eep0018_number() undefined
> ./include/jsx_common.hrl:100: type encoder_opt() undefined
> ./include/jsx_common.hrl:109: type decoder_opt() undefined
> ./include/jsx_common.hrl:117: type verify_opt() undefined
> ./include/jsx_common.hrl:123: type format_opt() undefined
> make[3]: *** [all] Error 1
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
