[ 
https://issues.apache.org/jira/browse/THRIFT-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13612479#comment-13612479
 ] 

Hudson commented on THRIFT-1861:
--------------------------------

Integrated in Thrift #633 (See [https://builds.apache.org/job/Thrift/633/])
    THRIFT-1861 PHP Makefile does not include TStringFuncFactory (Revision 
9b2524415c06d627e0cf6cfd5e038271a9bea9e0)

     Result = ABORTED
roger : 
https://git-wip-us.apache.org/repos/asf?p=thrift.git&a=commit&h=9b2524415c06d627e0cf6cfd5e038271a9bea9e0
Files : 
* lib/php/Makefile.am

                
> PHP Makefile does not include TStringFuncFactory
> ------------------------------------------------
>
>                 Key: THRIFT-1861
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1861
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Library
>    Affects Versions: 0.9
>         Environment: CentOs 6
>            Reporter: Logan Owen
>            Assignee: Roger Meier
>            Priority: Minor
>              Labels: build
>
> lib/php/Makefile.am does not include 
> lib/php/lib/Thrift/Factory/TStringFuncFactory.php in the files to be 
> installed.
> snippet of current Makefile.am:
> phpfactorydir = $(phpdir)/Factory
> phpfactory_DATA = \
>   lib/Thrift/Factory/TBinaryProtocolFactory.php \
>   lib/Thrift/Factory/TCompactProtocolFactory.php \
>   lib/Thrift/Factory/TJSONProtocolFactory.php \
>   lib/Thrift/Factory/TProtocolFactory.php \
>   lib/Thrift/Factory/TTransportFactory.php
> As you can see, it is missing TStringFuncFactory.php.
> Suggested change:
> phpfactorydir = $(phpdir)/Factory
> phpfactory_DATA = \
>   lib/Thrift/Factory/TBinaryProtocolFactory.php \
>   lib/Thrift/Factory/TCompactProtocolFactory.php \
>   lib/Thrift/Factory/TJSONProtocolFactory.php \
>   lib/Thrift/Factory/TProtocolFactory.php \
>   lib/Thrift/Factory/TStringFuncFactory.php \
>   lib/Thrift/Factory/TTransportFactory.php
> Looks like there was a similar issue with a different file in the past:  
> https://github.com/apache/thrift/commit/0b922740035d9c88f961dc0cd73b54350c68ea1c

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to