[
https://issues.apache.org/jira/browse/THRIFT-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655376#comment-13655376
]
Carl Yeksigian commented on THRIFT-1964:
----------------------------------------
I've resolved my concerns regarding the isset after deserialization. The reason
this works is because the XmlSerializer calls the properties and sets them
there, rather than rehydrating the values directly.
I think that we want to keep the Isset being [Serializable] for the Binary
serializer, since that actually does it by setting up the object the same way
that it was before.
I've attached a new patch that includes that change.
I haven't been able to test WCF yet because I'm having some issues running WCF
against Mono; I'll test when I have a Windows machine.
> 'Isset' will cause xmlserializer crashed.
> -----------------------------------------
>
> Key: THRIFT-1964
> URL: https://issues.apache.org/jira/browse/THRIFT-1964
> Project: Thrift
> Issue Type: Bug
> Components: C# - Compiler
> Affects Versions: 0.9
> Environment: .net framework 3.5
> Reporter: xq.gzh
> Labels: Isset
> Attachments: 1964-v2.patch, a.thrift, fix_isset_problem_test.zip,
> fix_Isset_xmlserializer.patch, Program.cs, ReproduceTheIssue.zip,
> THRIFT-1964_Isset_causes_xmlserializer_exeption.patch
>
> Original Estimate: 8h
> Remaining Estimate: 8h
>
> same class name 'Isset' in user defined class will cause xmlserializer
> crashed.
> below is the sample thrift:
> struct A {
> 1: string x;
> }
> struct B {
> 1: string y;
> }
> struct C {
> 1:A a
> 2:B b
> }
> generate code and try xmlserialize instance of class C. it crashed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
