agree! commit+document+test=release
;-r Quoting Jens Geyer <[email protected]>:
Sorry, just read it again :-) regarding the SLN ... if I dont have to build all of them, either way is fine with me. The main decision criterion for me would be automated build and test. $0,02 Jens ________________________________ Von: Carl Yeksigian (JIRA) Gesendet: 14.05.2013 16:21 An: [email protected] Betreff: [jira] [Updated] (THRIFT-1953) support for asp.net mvc 3 [ https://issues.apache.org/jira/browse/THRIFT-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carl Yeksigian updated THRIFT-1953: ----------------------------------- Attachment: 1953-remove-unused-variable.patch Thanks! Here is the error that I got when making the compiler: {code} src/generate/t_csharp_generator.cc: In member function ‘void t_csharp_generator::generate_ProcessRequest_function(t_service*, t_function*)’: src/generate/t_csharp_generator.cc:2582: warning: unused variable ‘first’ {code} I've attached a patch to remove the variable, rather than having more back and forth about that. I'd rather have them in a single solution, where we just don't build all of them. [~jensg] [~roger.meier]: Do either of you have an opinion on this?support for asp.net mvc 3 ------------------------- Key: THRIFT-1953 URL: https://issues.apache.org/jira/browse/THRIFT-1953 Project: Thrift Issue Type: New Feature Components: C# - Compiler, C# - Library Affects Versions: 0.9 Environment: .net framework 4.0 + asp.net mvc 3 Reporter: xq.gzh Priority: Minor Fix For: 0.9 Attachments: 1953-remove-unused-variable.patch, thrift-1953-asp.net-mvc-support-20130513.patch Original Estimate: 8h Remaining Estimate: 8h make asp.net mvc 3 can support thrift protocol-- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
