[
https://issues.apache.org/jira/browse/THRIFT-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13659948#comment-13659948
]
Phillip Campbell commented on THRIFT-1893:
------------------------------------------
I agree to the file names and folders. I was fighting a line between keeping
things consistent with the existing nodejs, regular javascript and ruby
implementations, and refactoring for code that I didn't know how to run tests
for. I'll make that refactor, no timelines promised.
So are you saying to use the javascript client side tests pointed at a nodejs
httpserver? Is that how other implementations are tested? Would would then be
the right way to test the http client if I finish it?
> HTTP server/client for node js
> ------------------------------
>
> Key: THRIFT-1893
> URL: https://issues.apache.org/jira/browse/THRIFT-1893
> Project: Thrift
> Issue Type: New Feature
> Components: Node.js - Library
> Affects Versions: 0.9
> Reporter: Phillip Campbell
> Priority: Minor
> Labels: node
> Fix For: 1.0
>
> Attachments: thrift-1893-node-http.patch
>
>
> I have written a http server for node js, and am in progress on a http client
> for node js. I will contribute a patch file when I am done, however I am
> having a few problems figuring out how things need to be implemented. I am
> trying to follow the ruby implementation as an example, but am unsure how to
> make sure I implement things correct. I assume the link in the README under
> requirements was supposed to explain these things, but currently
> http://wiki.apache.org/thrift/ThriftRequirements leads to gibberish.
> Questions I have are:
> Do I need to implement a JSON protocol?
> On an http request, do I need to ensure the request is a POST? Check for
> headers? What is required?
> Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
