[ 
https://issues.apache.org/jira/browse/THRIFT-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667930#comment-13667930
 ] 

Laurent Desegur commented on THRIFT-1600:
-----------------------------------------

Thanks Travis. This is great. However, now that the patches are applied, I 
still need to apply the fix for 1980 as goinstall isn't present and --with-go 
fails to build the go lib :( 

If I apply the patch attached to issue 1980 AFTER (minus the t_go_generator.cc 
changes I removed manually to avoid post merge conflict), I don't get with-go 
in configure.ac anymore (go is gone from the options). 

Travis: Is there a branch on apache.org/repos/asf/thrift.git or some place else 
if you don't have write access on apache (github?) with all the patches already 
applied so I can simply clone it? I sincerely appreciate your help.
                
> Thrift Go Compiler and Library out of date with Go 1 Release.
> -------------------------------------------------------------
>
>                 Key: THRIFT-1600
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1600
>             Project: Thrift
>          Issue Type: Bug
>          Components: Go - Compiler, Go - Library
>            Reporter: Atul S Vasu
>         Attachments: 
> 0002-Integrate-changes-from-github.com-pomack-thrift4go.patch, 
> 0003-Update-tutorial-code-for-go1.patch, 
> 0004-Fix-imports-add-package-prefixes-configurable-thrift.patch, 
> partial.diff, thrift-1600-go1-support.patch.gz
>
>
> Go 1 is a major release of Go that will be stable in the long term. Read the 
> Go 1 Release Notes for more information. 
> http://golang.org/doc/go1.html
> The current (trunk) compiler and libraries are not compatible with Go1, 
> because of significant changes in the language.
> The pomack/thrift4go seems a valid patch, but doesn't seem to be pulled into 
> Apache Thrift. Possibly merge the development into one place? 
> https://github.com/pomack/thrift4go

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to