[
https://issues.apache.org/jira/browse/THRIFT-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13678071#comment-13678071
]
Jonathan Ellis commented on THRIFT-820:
---------------------------------------
As I said three years ago, the intent appears to be providing frame-like
protection against OOM for unframed connections, but since it's languished
broken this long, and we presumably have way more modern framed connection
these days than otherwise, I suggest just ripping it out.
> The readLength attribute of TBinaryProtocol is used as an instance variable
> and is decremented on each call of checkReadLength
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-820
> URL: https://issues.apache.org/jira/browse/THRIFT-820
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
> Affects Versions: 0.2, 0.3
> Reporter: Nate McCall
> Fix For: 1.0
>
> Attachments: tbinaryprotocol-length-check-patch-THRIFT-820.txt
>
>
> When coding towards readLength, I saw this more as a check on the message
> length as it comes in. Perhaps its me, but I just dont see why this should
> decrement giving the length header for each message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
