Randy Abernethy created THRIFT-2056:
---------------------------------------
Summary: Moved all #include config.h statements to #include
<thrift/config.h>
Key: THRIFT-2056
URL: https://issues.apache.org/jira/browse/THRIFT-2056
Project: Thrift
Issue Type: Improvement
Components: C++ - Library
Affects Versions: 1.0
Environment: All
Reporter: Randy Abernethy
Assignee: Randy Abernethy
Priority: Minor
Fix For: 1.0
This is a follow on to THRIFT-2014.
Everything in the C++ lib is #include <thrift/*> except the config.h. The
attached patch changes all config.h includes to #include <thrift/config.h>.
This patch also creates a default thrift/config.h which is empty except for a
_WIN32 guarded include of thrift/windows/config.h. This will be overwritten by
configure/make/make install on *nix but will allow Windows users to just copy
the tree and go.
TODO:
-----
I have not addressed the HAVE_CONFIG guards yet. By providing an empty config.h
I can't see a scenario where HAVE_CONFIG is needed. Unless anyone can see a
reason to leave HAVE_CONFIG around I will remove the guard globally in a new
patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
