[
https://issues.apache.org/jira/browse/THRIFT-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13691617#comment-13691617
]
Christoffer Sawicki commented on THRIFT-1482:
---------------------------------------------
Here's an implementation I've used for quite some time:
https://gist.github.com/qerub/a027f0a6c8559a061bbc
It's basically a copy-and-paste of TSocket.php with some tweaks. Here's a diff:
https://gist.github.com/qerub/a027f0a6c8559a061bbc/revisions
I'd like to submit a patch for inclusion, but first some questions:
h5. How should the similarity between TCP and UNIX domain sockets be handled? I
see three options:
# The shared code can be pushed to a new ~TAbstractSocket.
# My class can be included as-is (with the code duplication).
# TSocket can be extended to handle both by having attributes for host, port
*and* filename. This is the way it is in the C++ implementation.
(lib/cpp/src/thrift/transport/TSocket.cpp)
What are your opinions?
h5. Should the class be called TUNIXSocket or TUnixSocket? There seems to be
multiple conventions in the PHP library. :)
> Unix domain socket support under PHP
> ------------------------------------
>
> Key: THRIFT-1482
> URL: https://issues.apache.org/jira/browse/THRIFT-1482
> Project: Thrift
> Issue Type: New Feature
> Components: PHP - Library
> Affects Versions: 0.8
> Reporter: Asad Saeed
> Assignee: Roger Meier
>
> I would like to use Unix domain sockets under PHP for TSocket and
> TServerSocket. Currently only tcp can be used.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
