[ 
https://issues.apache.org/jira/browse/THRIFT-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13710403#comment-13710403
 ] 

Jens Geyer commented on THRIFT-2090:
------------------------------------

Hi [~emiraga],

could you move the tests from /test/go into /lib/go/test?

Other than that it looks good to me.

                
> Go generator, fix including of other thrift files
> -------------------------------------------------
>
>                 Key: THRIFT-2090
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2090
>             Project: Thrift
>          Issue Type: Bug
>          Components: Go - Compiler
>            Reporter: Emir Habul
>              Labels: newbie, patch
>         Attachments: thrift-1-go-path.patch, thrift-2-fix-code.patch, 
> thrift-3-add-tests.patch, thrift-4-import-protection.patch
>
>
> When one thrift file includes another, we would generate incorrect code when 
> referencing types and services from the included file.
> Tests in test/go/ included.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to