[
https://issues.apache.org/jira/browse/THRIFT-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719184#comment-13719184
]
Jake Farrell commented on THRIFT-1357:
--------------------------------------
Hi Alisdair, we currently use JSX in one file (thrift_json_protocol.erl, link
below). we have experienced many issues with JSX downloading from github as a
external dependency and this causes the build to break, as a result we have
removed erlang from the debian package, rpm, and many other automated build
configurations we have. If you are willing to contribute your parser, or the
subset that we need based on usage within thrift_json_protocol, for inclusion
with Apache Thrift please attach the source code to this ticket you wish to
granting right of use to the ASF for that attached version. If you would like
to provide a patch for only the specific functionality that is needed within
thrift_json_protocol that would be a tremendous help as well. Either way,
appreciate any help you can provide in making the erlang build stable again.
https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=lib/erl/src/thrift_json_protocol.erl
> Erlang Dependency breaks build
> ------------------------------
>
> Key: THRIFT-1357
> URL: https://issues.apache.org/jira/browse/THRIFT-1357
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
> Affects Versions: 0.9
> Environment: Apache build Infrastructure based on Ubuntu lucid
> {noformat}
> ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP virtual machine and base applicat
> ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP cryprographic modules
> ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP development libraries and headers
> ii erlang-eunit 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP module for unit testing
> ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP modules for handling abstract Erl
> ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP virtual machine and base applicat
> ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP cryprographic modules
> ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP development libraries and headers
> ii erlang-eunit 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP module for unit testing
> ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP modules for handling abstract Erl
> {noformat}
> Reporter: Roger Meier
> Assignee: Jake Farrell
> Fix For: 0.9.1
>
> Attachments:
> 0001-Fixed-thrift_json_protocol.erl-to-work-with-JSX-v0.9.patch,
> 0001-updated-JSX-version.patch, thrift-1357.patch
>
>
> THRIFT-1227 introduced JSON for erlang,
> however the Ubuntu build infrastructur does not support this...
> {noformat}
> ./rebar get-deps
> ==> erl (get-deps)
> Pulling jsx from {git,"git://github.com/talentdeficit/jsx.git",{tag,"v0.9.0"}}
> Initialized empty Git repository in
> /home/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/erl/deps/jsx/.git/
> ==> nicefloats (get-deps)
> ==> jsx (get-deps)
> ./rebar compile
> ==> nicefloats (compile)
> Compiled src/nicefloats.erl
> ==> jsx (compile)
> ./include/jsx_common.hrl:34: type jsx_opt() undefined
> ./include/jsx_common.hrl:66: type jsx_parser_result() undefined
> ./include/jsx_common.hrl:82: type eep0018_array() undefined
> ./include/jsx_common.hrl:82: type eep0018_object() undefined
> ./include/jsx_common.hrl:84: type eep0018_term() undefined
> ./include/jsx_common.hrl:85: type eep0018_key() undefined
> ./include/jsx_common.hrl:85: type eep0018_term() undefined
> ./include/jsx_common.hrl:91: type eep0018_string() undefined
> ./include/jsx_common.hrl:92: type eep0018_number() undefined
> ./include/jsx_common.hrl:100: type encoder_opt() undefined
> ./include/jsx_common.hrl:109: type decoder_opt() undefined
> ./include/jsx_common.hrl:117: type verify_opt() undefined
> ./include/jsx_common.hrl:123: type format_opt() undefined
> make[3]: *** [all] Error 1
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
