[
https://issues.apache.org/jira/browse/THRIFT-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13741381#comment-13741381
]
Jens Geyer commented on THRIFT-6:
---------------------------------
{quote}
•replace -dev suffix always with "git rev-parse --short HEAD" ?
•use "git rev-parse --short HEAD" also for releases ?
{quote}
Maybe as an addon, but not as an replacement. The '-dev' makes it clear from
the beginning what it is, I personally like that. Having the git hash is a nice
thing too, since it clearly indicates the exact content of the binaries. So I'd
prefer to have it both.
{quote}
•how do we version csharp and delphi with the quadruple pattern 0.0.0.0 ? I
triple allowed?
•how to differentiate between release and development version?
release: 0.9.1.1
development: 0.9.1.0
{quote}
It's not primarily a Delphi/C# thing. Common standard on Windows (because of
the OS support) are version numbers with 4 parts. There are some minor
differences opinions on how to use them though. Microsoft prefers
Major.Minor.Build.Revision, while others prefer Major.Minor.Revision.Build. The
main reason of this confusion is a slightly different understanding of what the
terms "Revision" and "Build" actually mean. A good explanation can be found
[here|http://stackoverflow.com/questions/3098167/why-is-system-version-in-net-defined-as-major-minor-build-revision]
With regard to Thrift, I think what you proposed here is not so bad:
{quote}
[assembly: AssemblyVersion("0.9.1.0")]
[assembly: AssemblyFileVersion("0.9.1.0")]
[assembly: AssemblyInformationalVersion("0.9.1.0-2ca9c20")]
{quote}
hence the dev-build would be
{quote}
[assembly: AssemblyInformationalVersion("0.9.1.0-dev-8c64dc1")]
{quote}
> Thrift libraries and compiler lack version number
> -------------------------------------------------
>
> Key: THRIFT-6
> URL: https://issues.apache.org/jira/browse/THRIFT-6
> Project: Thrift
> Issue Type: Bug
> Reporter: Bryan Duxbury
> Assignee: Roger Meier
> Fix For: 1.0
>
> Attachments:
> 0001-THRIFT-6-Thrift-libraries-and-compiler-lack-version-.patch,
> ASF.LICENSE.NOT.GRANTED--v1-0001-THRIFT-6.-Add-a-Makefile-rule-to-print-the-version-f.patch,
> THRIFT-6_align_version_and_description_to_0.6.0-dev.patch
>
>
> Right now it's impossible to tell which version of Thrift you have installed.
> If you're depending on features that have recently been added (and that
> subtly don't exist), you can spend a lot of time chasing your tail trying to
> figure out what the problem is.
> This may be something that has to be implemented piecemeal on each client
> library (ruby gem, java classes, etc). Thoughts?
> While we're at it, let's add a --version switch or something to the compiler
> so you know what version of stuff you're actually generating.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
