[
https://issues.apache.org/jira/browse/THRIFT-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751254#comment-13751254
]
Henrique Mendonça commented on THRIFT-2058:
-------------------------------------------
Thanks for the interesting patch Hamed!
I've committed it with a little modification to ignore the reconnect by
default, i.e. if max_attempts is not defined
Cheers,
Henrique
> Add reconnect support to node.js library
> ----------------------------------------
>
> Key: THRIFT-2058
> URL: https://issues.apache.org/jira/browse/THRIFT-2058
> Project: Thrift
> Issue Type: New Feature
> Components: Node.js - Library
> Reporter: Hamed Madani
> Assignee: Henrique Mendonça
> Labels: nodejs
> Attachments: thrift-2058-nodejs-reconnect-v2.patch
>
>
> I've added reconnect support to node.js library.
> added 4 new parameters to options:
> {code}debug : (true or false) when true console.log reconnect events
> max_attempts : max number of reconnect attempts before giving up
> connect_timeout : max time before giving up reconnect attempts
> retry_max_delay : max time in millisecond between retry attempts
> {code}
> also added two new functions :
> {code}
> initialize_retry_vars() initialize the retry variables.
> connection_gone() gets called on 'close' event and tries to reconnect the
> connection.{code}
> *Update:* updated the patch to re-enable emitting the 'error' event.
> ("error" events get turned into exceptions if they aren't listened for. If
> the user handled this error then we should try to reconnect.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
