[ 
https://issues.apache.org/jira/browse/THRIFT-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754995#comment-13754995
 ] 

Jake Farrell commented on THRIFT-2155:
--------------------------------------

Hi [~karthick.selvaraj], thanks for the patch. All of these items are auto 
generated by the build tools and should not require manual intervention. 

- version.h is auto generated from the version.h.in template, it should not be 
renamed/modified manually 

- thrifty.h vs .hh is due to the autoconf version in use on your system. In the 
0.9.1 release I overrode the macro used to always default to .h to fix this for 
us. Are you seeing an issue with this on trunk?


                
> Adding one liner guide to rename the version.h.in and rename thrifty.cc.h
> -------------------------------------------------------------------------
>
>                 Key: THRIFT-2155
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2155
>             Project: Thrift
>          Issue Type: Documentation
>          Components: Compiler (General)
>            Reporter: Karthick Selvaraj
>            Priority: Trivial
>              Labels: newbie, patch
>         Attachments: thrift-2155.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Adding few lines in /compiler/cpp/README_Windows.txt.
> Adding one liner guide to rename the version.h.in to version.h before 
> building the compiler using VS.
> Adding one liner guide to rename the thrifty yacc header file, if bison left 
> it with ".h"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to