[
https://issues.apache.org/jira/browse/THRIFT-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13789723#comment-13789723
]
Ben Craig commented on THRIFT-1751:
-----------------------------------
I can do that. In either case, you will get an error if you call
increase_max_fds without HAVE_SYS_RESOURCE_H. Guarding it in the header means
that clients get a compiler time error instead of a link time error. I will
update accordingly.
> definition of increase_max_fds doesn't compile when HAVE_SYS_RESOURCE_H is
> not defined
> --------------------------------------------------------------------------------------
>
> Key: THRIFT-1751
> URL: https://issues.apache.org/jira/browse/THRIFT-1751
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9, 1.0
> Reporter: Ben Craig
> Assignee: Ben Craig
> Fix For: 1.0
>
> Attachments: TServer_guard.patch
>
>
> The definition of increase_max_fds uses struct rlimit, which is defined in
> sys/resource.h. If sys/resource.h doesn't get included, you get a compiler
> error.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
