[ 
https://issues.apache.org/jira/browse/THRIFT-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790943#comment-13790943
 ] 

Hudson commented on THRIFT-2027:
--------------------------------

SUCCESS: Integrated in Thrift #926 (See 
[https://builds.apache.org/job/Thrift/926/])
THRIFT-2027: Minor 64-bit and NOMINMAX issues in C++ library (bencraig: rev 
6493523e96df96069c94647c5e9b841b0be491a6)
* lib/cpp/src/thrift/transport/TZlibTransport.cpp
* lib/cpp/src/thrift/server/TNonblockingServer.cpp
* lib/cpp/src/thrift/transport/THttpServer.cpp


> Minor 64-bit and NOMINMAX issues in C++ library
> -----------------------------------------------
>
>                 Key: THRIFT-2027
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2027
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9
>         Environment: 64-bit.  Windows without NOMINMAX set.
>            Reporter: Ben Craig
>            Assignee: Ben Craig
>            Priority: Minor
>             Fix For: 1.0
>
>         Attachments: misc_minor.patch
>
>
> TNonblockingServer and THttpServer have size_t -> uint32_t truncations.
> TZlibTransport calls std::min without enclosing it in parens.  This is a 
> really minor issue, since we technically build with NOMINMAX in the 
> environment (which fixes the problem), but I have a strange personal goal of 
> being able to build without setting NOMINMAX.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to