[
https://issues.apache.org/jira/browse/THRIFT-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812333#comment-13812333
]
Jens Geyer commented on THRIFT-2247:
------------------------------------
Hi [~tonnerre],
many thanks for the patch.
Two remarks/questions though:
- The patch fails to apply to current trunk at the BeginMap/Set/List parts
around line 25xx, unfortunately.
- Is there any chance to enhabce the patch in a way that it also solves
THRIFT-2063?
> Go generator doesn't deal well with map keys of type binary
> -----------------------------------------------------------
>
> Key: THRIFT-2247
> URL: https://issues.apache.org/jira/browse/THRIFT-2247
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
> Affects Versions: 1.0
> Environment: Linux phileas 3.2.0-4-amd64 #1 SMP Debian
> 3.2.46-1+deb7u1 x86_64 GNU/Linux (testing/jessie)
> Reporter: Tonnerre Lombard
> Attachments:
> 0001-THRIFT-2247-Fix-handling-of-binary-keys-in-maps-for-.patch
>
>
> The current Go generator doesn't deal well with maps where the map key is
> []byte. For some weird reason, you just can't have a map[[]byte]foo in Go, so
> we have to go for map[string]foo, which is actually equivalent (Go strings
> preserve all bytes).
> I'm trying to come up with a patch for this.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
