Thank you very much, but for legal reasons we cannot accept pull requests. Please have a look at http://thrift.apache.org/docs/HowToContribute. A bugfix for this particular issue has been committed just yesterday.
Thanks again, JensG ________________________________ Von: wizardcypress Gesendet: 29.11.2013 00:39 An: [email protected] Betreff: thrift pull request: fix bug in compatc_protocol.go, prevent memory leak GitHub user wizardcypress opened a pull request: https://github.com/apache/thrift/pull/69 fix bug in compatc_protocol.go, prevent memory leak After a long time running on compatct protocol, I found that the memory still increase and never drop. By using go tool pprof, I found that p.lastField grows and never decrease. So I realized that in function `ReadStructEnd` there should pop the last element to prevent memory leak. You can merge this pull request into a Git repository by running: $ git pull https://github.com/wizardcypress/thrift master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/69.patch ---- commit bc1a7545d95c1b5f65ad3fe95039bacfa5b51fe7 Author: cypress <[email protected]> Date: 2013-11-28T09:53:21Z fix bug in compatc_protocol.go, prevent memory leak ----
