[
https://issues.apache.org/jira/browse/THRIFT-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838345#comment-13838345
]
Andreas Fuchs edited comment on THRIFT-2219 at 12/19/13 6:46 AM:
-----------------------------------------------------------------
Looks like Ben Nham's diagnosis is correct: The declaration of strlcpy there
causes badness. Removing that #else branch on the strlcpy.h ifdef seems to do
the trick. This is essentially the same change as
https://github.com/nearbuy/thrift/commit/b20535e9d58e0f099338f690bab856ceb0041e63,
but I decided to remove the now-useless #else as well.
I tested this in 10.9 and on Linux, and the gem builds there. I'll test on 10.7
later today (as soon as I get access to a machine running it); I hope that will
give us enough certainty this is the correct change to make.
(This is my first submission to the Apache JIRA; please let me know if I
screwed anything up :))
was (Author: antifuchs):
Looks like Ben Nham's diagnosis is correct: The declaration of strlcpy there
causes badness. Removing that #else branch on the strlcpy.h ifdef seems to do
the trick. This is essentially the same change as
https://github.com/nearbuy/thrift/commit/b20535e9d58e0f099338f690bab856ceb0041e63,
but I decided to remove the now-useless #else as well.
I tested this in 10.9 and on Linux, and the gem builds there. I'll test on 10.7
later today (as soon as I get access to a machine running it); I hope that will
give us enough certainty this is the correct change to make.
(This is my first submission to the Apache JIRA; please let me know if I
screwed anything up (-:)
> Thrift gem fails to build on OS X Mavericks with 1.9.3 rubies
> -------------------------------------------------------------
>
> Key: THRIFT-2219
> URL: https://issues.apache.org/jira/browse/THRIFT-2219
> Project: Thrift
> Issue Type: Bug
> Components: Ruby - Library
> Affects Versions: 0.9.1
> Environment: OS X Mavericks (GM), ruby 1.9.3-p448 built with
> rbenv/ruby-build
> Reporter: Chris Anderson
> Fix For: 0.9.2
>
> Attachments: thrift-2219-no-strlcpy-redeclaration.patch
>
>
> (Preface, this issue is for the unreleased OS X Mavericks, so understand if
> it's not fixable now, just wanted to bring it up.)
> I'm unable install the 0.9.1 thrift gem on my GM OS X Mavericks system with
> ruby 1.9.3-p448. I get the error `extconf.rb:25: Use RbConfig instead of
> obsolete and deprecated Config.` along with some strlcopy errors.
> Strack trace is at (https://gist.github.com/chrismanderson/6834809)
> Oddly, I CAN install the 0.9.1 gem with both 2.0.0-p247 and
> ree-1.8.7-2011.12. I also tried 1.9.3-p194 and p429 and got the same error.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
