[ 
https://issues.apache.org/jira/browse/THRIFT-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13854763#comment-13854763
 ] 

venura commented on THRIFT-2293:
--------------------------------

Hi Andreas ,

These FileInputStream objects are not closed anywhere IFAIK. I faced the same 
problem and patched the code. Now it works fine.
Please find the attached patch TSSLTransportFactory.diff. 

Regards,
Venura

> TSSLTransportFactory.createSSLContext() leaves files open
> ---------------------------------------------------------
>
>                 Key: THRIFT-2293
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2293
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Library
>    Affects Versions: 0.9.1
>         Environment: Windows 7, Java 7
>            Reporter: Andreas Sjöholm
>            Priority: Minor
>              Labels: file, leak
>         Attachments: TSSLTransportFactory.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Even though my thrift server is shutdown and (perhaps?) GC'ed, 
> the keystore file used is still locked by the VM.
> In TSSLTransportFactory.createSSLContext() i see  
> ks.load(new FileInputStream(params.keyStore), params.keyPass.toCharArray());
> The FileInputStreams are never closed, which they should.
> Or is this done deliberately?



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to