[
https://issues.apache.org/jira/browse/THRIFT-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13856982#comment-13856982
]
Jens Geyer edited comment on THRIFT-2295 at 12/26/13 6:19 PM:
--------------------------------------------------------------
{quote}
> None = 0x01 ...
Only for the Bit-test. (x & 0x0 = 0x0).
{quote}
I would expect None to be literally "no bits set".
{quote}
most likely the person who implemented oneway didn't know it too
{quote}
Not quite, I think. The keyword *oneway* lets the code generator behave
differently: It omits the whole recv_Xxx() response part. I asked for
annotations, because from what I understand so far, the behaviour for oneway,
signal or slot might be the same, and you want to achieve something
additionally beyond that. That's why I think, shedding some more light on it
could be helpful to know what you want to achieve, or what you feel is missing
from Thrift to "_connect different services together_".
was (Author: jensg):
{quote}
> None = 0x01 ...
Only for the Bit-test. (x & 0x0 = 0x0).
{quote}
I would expect None to be "no bits set".
{quote}
most likely the person who implemented oneway didn't know it too
{quote}
Not quite, I think. The keyword *oneway* lets the code generator behave
differently: It omits the whole recv_Xxx() response part. I asked for
annotations, because from what I understand so far, the behaviour for oneway,
signal or slot might be the same, and you want to achieve something
additionally beyond that. That's why I think, shedding some more light on it
could be helpful to know what you want to achieve, or what you feel is missing
from Thrift to "_connect different services together_".
> Make "oneway" more generic
> --------------------------
>
> Key: THRIFT-2295
> URL: https://issues.apache.org/jira/browse/THRIFT-2295
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
> Affects Versions: 0.9.1
> Reporter: Martin Vogt
> Priority: Trivial
> Attachments: functionModifiers.patch
>
>
> I'm experimenting with different function modifiers
> ("oneway","signal","slot", etc...)
> The current code does not make such tests easy, because the "oneway"
> modifier is hardcoded as bool.
> The following patch improves the optional function modifier to be more
> generic.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
