[jira] [Comment Edited] (THRIFT-2204) SSL client for the cocoa client

[Ted Rogers (JIRA)]

    [ 
https://issues.apache.org/jira/browse/THRIFT-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859743#comment-13859743
 ] 

Ted Rogers edited comment on THRIFT-2204 at 12/31/13 10:36 PM:
---------------------------------------------------------------

I am having the same problem applying the patch.  I just updated this comment 
with the verbose output of the --check option.

Any ideas?

$ git apply -v --check ../thrift-2204-SSL_client_for_the_cocoa_client.patch

Checking patch lib/cocoa/src/transport/TNSStreamTransport.h...
error: while searching for:
#import "TTransport.h"

@interface TNSStreamTransport : NSObject <TTransport> {

}

@property (nonatomic) NSInputStream * mInput;
@property (nonatomic) NSOutputStream * mOutput;

- (id) initWithInputStream: (NSInputStream *) input
              outputStream: (NSOutputStream *) output;


error: patch failed: lib/cocoa/src/transport/TNSStreamTransport.h:21
error: lib/cocoa/src/transport/TNSStreamTransport.h: patch does not apply
Checking patch lib/cocoa/src/transport/TNSStreamTransport.m...
error: while searching for:
              outputStream: (NSOutputStream *) output
{
  self = [super init];
  self.mInput = [input retain_stub];
  self.mOutput = [output retain_stub];
  return self;
}


error: patch failed: lib/cocoa/src/transport/TNSStreamTransport.m:28
error: lib/cocoa/src/transport/TNSStreamTransport.m: patch does not apply
Checking patch lib/cocoa/src/transport/TSSLSocketClient.h...
error: lib/cocoa/src/transport/TSSLSocketClient.h: No such file or directory
Checking patch lib/cocoa/src/transport/TSSLSocketClient.m...
error: lib/cocoa/src/transport/TSSLSocketClient.m: No such file or directory
Checking patch lib/cocoa/src/transport/TSSLSocketException.h...
error: lib/cocoa/src/transport/TSSLSocketException.h: No such file or directory
Checking patch lib/cocoa/src/transport/TSSLSocketException.m...
error: lib/cocoa/src/transport/TSSLSocketException.m: No such file or directory


was (Author: tmrog):
I am having the same problem applying the patch.  Any ideas?
$ git apply --check ../thrift-2204-SSL_client_for_the_cocoa_client.patch
error: patch failed: lib/cocoa/src/transport/TNSStreamTransport.h:21
error: lib/cocoa/src/transport/TNSStreamTransport.h: patch does not apply
error: patch failed: lib/cocoa/src/transport/TNSStreamTransport.m:28
error: lib/cocoa/src/transport/TNSStreamTransport.m: patch does not apply
error: lib/cocoa/src/transport/TSSLSocketClient.h: No such file or directory
error: lib/cocoa/src/transport/TSSLSocketClient.m: No such file or directory
error: lib/cocoa/src/transport/TSSLSocketException.h: No such file or directory
error: lib/cocoa/src/transport/TSSLSocketException.m: No such file or directory

> SSL client for the cocoa client
> -------------------------------
>
>                 Key: THRIFT-2204
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2204
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Cocoa - Library
>    Affects Versions: 0.9.1
>            Reporter: Olivier Van Acker
>             Fix For: 0.9.2
>
>         Attachments: thrift-2204-SSL_client_for_the_cocoa_client.patch
>
>
> The cocoa library doesn't have a SSL transport client (TSSLSocketClient) 
> needed for secure connections



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)