Hey Jens, The 0002-repairs-Node-JSON-and-Buffer-and-adds-tests.patch should apply clean to the current trunk. It fixes many issues with Node TJSONProtocol and TBufferedTransport. Some other good patches have come in while I was working on this one. However, the main feature of this patch is the test updates. Currently Node has a server.js and client.js test using TFramedTransport and TBinaryProtocol (in thrift/test/nodejs/). This new patch centralizes the standard Apache Thrift test handler and driver code and adds a server_json.js and client_json.js test which tests TJSONProtocol and TBufferedTransport (both of which had many bugs which needed to be repaired to pass the tests). I could find no Jira source patches for all of the repairs required elsewhere so I supplied all of the needed code with this patch.
This patch also completes the previous work on the test.html/test.js browser based test, which now runs clean against the server_http.js node backend (which also uses the centralized Node test handler). Apologies for the mondo patch but it was all sort of linked together. Note that I did not update the thrift/test/nodejs/Makefile. The client.js/server.js test still runs clean on make with my boxes but I didn't add in the new tests. I saw a note from Henrique mentioning possibly moving the node tests and figured it might be best to update the build in a later patch. Best, Randy On Wed, Jan 8, 2014 at 12:14 AM, Jens Geyer <[email protected]> wrote: > Would someone of the people using Node volunteer to coordinate all these > patches to get an accepted and agreed patch (or patch set)? I do not use > Node myself yet, but I'd love to see all these issues fixed, simply because > it is Node. > ________________________________ > Von: Randy Abernethy (JIRA) > Gesendet: 08.01.2014 04:23 > An: [email protected] > Betreff: [jira] [Updated] (THRIFT-2205) Node.js Test Server to support > test.js JavaScript Browser test and sundry fixes > > > [ > https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel] > > Randy Abernethy updated THRIFT-2205: > ------------------------------------ > > Attachment: 0002-repairs-Node-JSON-and-Buffer-and-adds-tests.patch > > patch > > > Node.js Test Server to support test.js JavaScript Browser test and > sundry fixes > > > ------------------------------------------------------------------------------- > > > > Key: THRIFT-2205 > > URL: https://issues.apache.org/jira/browse/THRIFT-2205 > > Project: Thrift > > Issue Type: Improvement > > Components: JavaScript - Library, Node.js - Library > > Affects Versions: 1.0 > > Environment: All > > Reporter: Randy Abernethy > > Assignee: Randy Abernethy > > Priority: Minor > > Labels: node, nodejs > > Attachments: > 0002-repairs-Node-JSON-and-Buffer-and-adds-tests.patch > > > > > > Adds lib/nodejs/test/testsvr.js > > This server depends on ThriftTest[.js] and runs clean with test.js in > the browser. > > Also in this patch: > > Repairs some shortfall in the Node JSON Protocol and transport. Fixes > overflow on Javascript I64 tests. Improves static_server header output. > > > > -- > This message was sent by Atlassian JIRA > (v6.1.5#6160) >
