GitHub user sharrajesh opened a pull request:
https://github.com/apache/thrift/pull/78
Update TSSLServerSocket.cpp
I think it's a bug to declare createSocket with parameters "int socket"
while the base class
TServerSocket declares the virtual function createSocket with parameters
"THRIFT_SOCKET socket"
On windows THRIFT_SOCKET resolves to UINT_PTR hence
TSSLServerSocket::createSocket function
did not get called from the guts.
Hence a nasty hanging problem was happening for me while testing ssl
feature using official test_server/test_client.
I also posted my question at
http://stackoverflow.com/questions/21213094/c-thrift-client-not-working-with-ssl-ssl-connect-hangs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sharrajesh/thrift patch-4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/78.patch
----
commit a3de09c52139980aea2d82c89810dd467b3c5a71
Author: Rajesh Sharma <[email protected]>
Date: 2014-01-20T03:02:00Z
Update TSSLServerSocket.cpp
I think it's a bug to declare createSocket with parameters "int socket"
while the base class
TServerSocket declares the virtual function createSocket with parameters
"THRIFT_SOCKET socket"
On windows THRIFT_SOCKET resolves to UINT_PTR hence
TSSLServerSocket::createSocket function
did not get called from the guts.
Hence a nasty hanging problem was happening for me while testing ssl
feature using official test_server/test_client.
I also posted my question at
http://stackoverflow.com/questions/21213094/c-thrift-client-not-working-with-ssl-ssl-connect-hangs
----