Nevo Hed created THRIFT-2333:
--------------------------------
Summary: RPMBUILD: Abort build if user did not disable ruby but
ruby build will fail later on
Key: THRIFT-2333
URL: https://issues.apache.org/jira/browse/THRIFT-2333
Project: Thrift
Issue Type: Improvement
Environment: RPM environments
Reporter: Nevo Hed
Assignee: Nevo Hed
Priority: Minor
As can be seen in this email message to the users list it is possible for some
pre-required packages to be missing, but the traditional method for validating
their existence in specfile using "BuildRequires" won't work for items that are
not commonly available as RPMS.
http://mail-archives.apache.org/mod_mbox/thrift-user/201401.mbox/%3CCACeqxwQrLr7ghoBmbabQpu7z_u0FHjh+vbYXQKwP8=ibr4b...@mail.gmail.com%3E
I think that in this user's case the missing bit is the bundler gem, which I
have a locally built RPM for, but I have to assume that most folks do not and
it is not commonly available in most repos (not that I saw as a Centos6.4 user
anyway)
The patch I am attaching just checks if ruby subpackage was not disabled at the
(at the buildrpm level) and if the results of ./configure have determined that
"make install" won't build the gem (and so the rpm build of the rubygem-thrift
subpackage is bound to fail) abort the build with a clear message
An alternative solution MAY be to just dynamically skip that package when it is
detected that ./configure excluded ruby (I don't know off hand how to do that)
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
