[
https://issues.apache.org/jira/browse/THRIFT-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910885#comment-13910885
]
Hudson commented on THRIFT-2305:
--------------------------------
FAILURE: Integrated in Thrift #1061 (See
[https://builds.apache.org/job/Thrift/1061/])
THRIFT-2305 TFramedTransport empty constructor should probably be private
(jensg: rev f36fda203565430086e23ab6a231fdc5ec3d4b48)
* lib/csharp/src/Transport/TStreamTransport.cs
* lib/csharp/src/Transport/TSocket.cs
* lib/csharp/src/Transport/TFramedTransport.cs
> TFramedTransport empty constructor should probably be private
> -------------------------------------------------------------
>
> Key: THRIFT-2305
> URL: https://issues.apache.org/jira/browse/THRIFT-2305
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Library
> Reporter: Alex Ausch
> Assignee: Jens Geyer
> Priority: Trivial
> Fix For: 0.9.2
>
> Attachments: TFramedTransport_cs_refactor.patch,
> THRIFT-2305-misc-Transport_refactorings_v2.patch
>
>
> A TFramedTransport without an inner transport doesn't make sense.
> Therefore, the empty constructor should probably not be public - most likely
> private (possibly protected?).
> Attaching patch file, including some formatting corrections.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
