[
https://issues.apache.org/jira/browse/THRIFT-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13922451#comment-13922451
]
Carl Yeksigian commented on THRIFT-2391:
----------------------------------------
Thanks for the contribution! A few comments on this:
# The equivalent names in other languages is just TSocket, so it's probably
better to rename it to that
# The commented out call to debugBuffer should be removed in read, and the
exception comment should be elaborated
# The debugBuffer method should be removed as it isn't used
> simple socket transport for actionscript 3.0
> --------------------------------------------
>
> Key: THRIFT-2391
> URL: https://issues.apache.org/jira/browse/THRIFT-2391
> Project: Thrift
> Issue Type: Improvement
> Components: AS3 - Library
> Reporter: dima levchenko
> Priority: Minor
> Attachments:
> THRIFT-2391-simple-socket-transport-for-acrionscript-3.0.patch
>
>
> working with thrift in actionscript 3.0 environment, i found only two
> transports in it's library - THttpClient and TFullDuplexHttpClient. Both were
> incompatible with TServerSocket implemented in java.
> I found it easy to implement compatible client transport with simple
> manipulations with TFullDuplexHttpClient, which i wish to suggest in patch. i
> called it TSocketClient. I wonder if it is a good name?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
