[
https://issues.apache.org/jira/browse/THRIFT-2390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939127#comment-13939127
]
ASF GitHub Bot commented on THRIFT-2390:
----------------------------------------
GitHub user gruzovator opened a pull request:
https://github.com/apache/thrift/pull/83
THRIFT-2390 nodejs lib fix
fix for THRIFT-2390 (no close event when connection lost)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gruzovator/thrift
fix-no-close-event-when-connection-lost
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/83.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #83
----
commit 270183f0507afc4346486cb58b8a684174eb13db
Author: gruzovator <[email protected]>
Date: 2014-03-18T12:23:21Z
fix for THRIFT-2390
fix for THRIFT-2390 (no close event when connection lost)
----
> no close event when connection lost
> -----------------------------------
>
> Key: THRIFT-2390
> URL: https://issues.apache.org/jira/browse/THRIFT-2390
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Reporter: alexey
>
> thrift nodejs lib (master)
> There is no indication that connection lost if reconnect is not setup.
> (There is no "close" event from connection object or RPC error callback)
> File: connection.js:167
> Connection.prototype.connection_gone = function () {
> var self = this;
> // If a retry is already in progress, just let that happen
> if (this.retry_timer || !this.max_attempts) {
> return;
> }
> Should be changed to
> Connection.prototype.connection_gone = function () {
> var self = this;
> // If a retry is already in progress, just let that happen
> if (this.retry_timer) {
> return;
> }
> if(!this.max_attempts) {
> self.emit("close");
> return;
> }
--
This message was sent by Atlassian JIRA
(v6.2#6252)
