[
https://issues.apache.org/jira/browse/THRIFT-2361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939182#comment-13939182
]
Ben Craig commented on THRIFT-2361:
-----------------------------------
Caveat: I'm not an expert on libevent. I also haven't really used
TNonBlockingServer much in practice. I also haven't tested this patch.
That being said, this patch looks reasonable. I'm not 100% sure on the exact
use case this is trying to solve, but I have certainly had cases where I wanted
some messages / clients to get a higher priority message. The change also
looks to be low risk to the existing code base. If we decide we want to do
something drastically different later, then we will likely be able to do the
different thing in addition to this patch, without breaking it.
> TNonBlockingServer: Provide ability to specify libevent priority
> -----------------------------------------------------------------
>
> Key: THRIFT-2361
> URL: https://issues.apache.org/jira/browse/THRIFT-2361
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Nevo Hed
> Priority: Minor
> Attachments: THRIFT2361.patch
>
>
> We have a single threaded thrift C++ app that instantiates multiple
> TNonblockingServer and attaches (registerEvents) them to a single
> (libevent) event_base.
> We wanted to give certain APIs higher priority. and the attached patch does
> so.
> We ended up NOT using this as our issue turned out to be elsewhere. But it
> seemed like others may be able to make use of this.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
