[
https://issues.apache.org/jira/browse/THRIFT-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958414#comment-13958414
]
Ben Craig commented on THRIFT-2421:
-----------------------------------
original pull request + self assignment pull request: +0.9 (looks good to me,
but I haven't tested them)
unittest + .cpp file stuff, two minor issue.
* You say declaration, but you are providing the definition. In C++, the
declaration is something like a function signature / prototype, and the
definition is where the body / guts of things are. A simple find+replace
should be able to fix this issue.
* Add a newline to the end of Recursive.thrift.
Once you make those two minor changes, I can give you a +0.9 on that as well.
Thanks for the work here, and being so responsive on the code reviews.
> Tree/Recursive struct support in thrift
> ---------------------------------------
>
> Key: THRIFT-2421
> URL: https://issues.apache.org/jira/browse/THRIFT-2421
> Project: Thrift
> Issue Type: Sub-task
> Components: C++ - Library
> Reporter: Jake Farrell
> Assignee: Jake Farrell
> Fix For: 0.9.2
>
> Attachments: 84.patch, tree_and_recursive_structs.thrift
>
>
> Patches to implement tree/list/co-recursive structures in thrift
> https://github.com/apache/thrift/pull/84
--
This message was sent by Atlassian JIRA
(v6.2#6252)
