[
https://issues.apache.org/jira/browse/THRIFT-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960118#comment-13960118
]
ASF GitHub Bot commented on THRIFT-1681:
----------------------------------------
Github user jfarrell commented on the pull request:
https://github.com/apache/thrift/pull/92#issuecomment-39585543
Hey @djwatson, thanks for another patch, really appreciate your
contributions back to Apache Thrift. looking at it quickly config check are
good, compiler looks good, files added to dist (thanks, this often gets missed)
and lib with test cases look good, if you could address the following I think
this can get merged in
- Facebook license headers on some of the files, needs to be replaced with
the Apache license version 2.0 headers
- Not that big a deal, but Andrews is assigned one of the leftover TODO
tags, just need to add the note on whats needed and remove his id from it
Thanks again
-Jake
> Add Lua Support
> ---------------
>
> Key: THRIFT-1681
> URL: https://issues.apache.org/jira/browse/THRIFT-1681
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Daurn Imator
> Assignee: Roger Meier
> Labels: language, lua
> Fix For: 0.9.2
>
>
> I'd love to see a lua library for Thift.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
