[
https://issues.apache.org/jira/browse/THRIFT-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971483#comment-13971483
]
ASF GitHub Bot commented on THRIFT-2470:
----------------------------------------
GitHub user adam-resdiary opened a pull request:
https://github.com/apache/thrift/pull/100
THRIFT-2470: Stop THttpHandler from swallowing processor exceptions
The problem with the way it works currently is that it makes it very
difficult to figure out what's going on when I've got a handler running on a
remote web server. If the handler just allows the exceptions to bubble up like
normal, they get caught by our normal exception handling code and logged.
I also added a new project for unit tests, and some tests for the changes
I've made.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/adam-resdiary/thrift ReportErrors
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/100.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #100
----
commit 6dcb1c3dc5d3259574863f0bc6af67b241b4653e
Author: Adam Connelly <[email protected]>
Date: 2014-04-16T14:37:54Z
THRIFT-2470: Stop THttpHandler from swallowing processor exceptions
The problem with the way it works currently is that it makes it very
difficult to figure out what's going on when I've got a handler running on a
remote web server. If the handler just allows the exceptions to bubble up like
normal, they get caught by our normal exception handling code and logged.
I also added a new project for unit tests, and some tests for the changes
I've made.
----
> THttpHandler swallows exceptions from processor
> -----------------------------------------------
>
> Key: THRIFT-2470
> URL: https://issues.apache.org/jira/browse/THRIFT-2470
> Project: Thrift
> Issue Type: Bug
> Components: C# - Library
> Affects Versions: 0.9.1
> Reporter: Adam Connelly
>
> The THttpHandler.ProcessRequest() method currently swallows any exceptions by
> the processor, and writes them out to Console.Error. This makes it very
> difficult to figure out what's going on if an exception is thrown in anything
> other than a console application.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
