[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974274#comment-13974274
]
Ben Craig commented on THRIFT-2471:
-----------------------------------
I'd rather not try to fix cycles magically. MSRPC / DCE tries to do lots of
smart things with pointers, and it's hard to understand, and hard to maintain.
I could see adding cycle detection, and if we encounter a cycle, throw an
exception.
I'd rather us not tackle the issue of de-duplicating nodes in a graph and then
hooking the graph back together on the other end of the wire. That seems like
a reasonable thing to do on top of Thrift, but I don't want it done within
Thrift.
> Make cpp.ref annotation language agnostic
> -----------------------------------------
>
> Key: THRIFT-2471
> URL: https://issues.apache.org/jira/browse/THRIFT-2471
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
> Reporter: Jens Geyer
>
> The proposal is to make the new {{cpp.ref}} annotation introduced with
> THRIFT-2421 language agnostic instead of a C++ specialty only.
> The annotation changes inlined nested structs into pointers to structs. This
> behaviour is potentially relevant with all languages using value semantics
> for nested structs etc.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
