[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974315#comment-13974315
]
Jens Geyer edited comment on THRIFT-2471 at 4/18/14 6:11 PM:
-------------------------------------------------------------
{quote}
I'd rather not try to fix cycles magically. MSRPC / DCE tries to do lots of
smart things with pointers, and it's hard to understand, and hard to maintain.
{quote}
That was one of the reasons for {{graph<>}} (see THRIFT-2005), it is designed
as an _extension_ on top of the the existing stuff, not interfering with it.
Internally, {{graph<>}} uses a container and serializes as a {{list<>}} of node
data. If one choses to use a {{graph<>}}, it would be an design decision.
There is a lengthy discussion about that topic in the mailing list archives.
There is also one mail from me with (Aug 2013, IIRC) holding a bunch of links
to these threads.
was (Author: jensg):
{quote}
I'd rather not try to fix cycles magically. MSRPC / DCE tries to do lots of
smart things with pointers, and it's hard to understand, and hard to maintain.
{quote}
That was one of the reasons for {{graph<>}} (see THRIFT-2005), it is designed
as an _extension_ on top of the the existing stuff, not interfering with it.
Internally, {{graph<>}} uses a container and serializes as a {{list<>}} of node
data. If one choses to use a {{graph<>}}, it would be an design decision.
> Make cpp.ref annotation language agnostic
> -----------------------------------------
>
> Key: THRIFT-2471
> URL: https://issues.apache.org/jira/browse/THRIFT-2471
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
> Reporter: Jens Geyer
>
> The proposal is to make the new {{cpp.ref}} annotation introduced with
> THRIFT-2421 language agnostic instead of a C++ specialty only.
> The annotation changes inlined nested structs into pointers to structs. This
> behaviour is potentially relevant with all languages using value semantics
> for nested structs etc.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
