[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980184#comment-13980184
]
Jens Geyer edited comment on THRIFT-2457 at 4/24/14 8:09 PM:
-------------------------------------------------------------
{quote}
But how will versioning the protocol here improve the situation?
{quote}
Not much. The main issue is that the current protocol leaves not much room for
adding new type codes without breaking compatibility, because the size of all
type codes is known, with one exception.
{quote}
I think that would require making 'float' look like an existing, skippable type
though.
{quote}
Well, this could work out. In fact, it has been done once already, with
{{binary}} which is serialized the same way as {{string}} is. If I don't
overlook anything, we simply have to pack the data into an type of equivalent
size and let the generated code handle the rest. No version bump needed, older
IDL compilers will fail at that stage because they don't have a clue about
{{float}}.
was (Author: jensg):
{quote}
But how will versioning the protocol here improve the situation?
{quote}
Not much. The main issue is that the current protocol leaves not much room for
adding new type codes.
{quote}
I think that would require making 'float' look like an existing, skippable type
though.
{quote}
Well, this could work out. In fact, it has been done once already, with
{{binary}} which is serialized the same way as {{string}} is. If I don't
overlook anything, we simply have to pack the data into an type of equivalent
size and let the generated code handle the rest. No version bump needed, older
IDL compilers will fail at that stage because they don't have a clue about
{{float}}.
> fbthrift float
> --------------
>
> Key: THRIFT-2457
> URL: https://issues.apache.org/jira/browse/THRIFT-2457
> Project: Thrift
> Issue Type: Sub-task
> Components: Build Process, C++ - Compiler, C++ - Library, Test Suite
> Reporter: Roger Meier
> Priority: Minor
> Fix For: 1.0
>
>
> I'm interested into the fbthrift FLOAT data type.
> Which languages are supported?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
