[ 
https://issues.apache.org/jira/browse/THRIFT-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982409#comment-13982409
 ] 

ASF GitHub Bot commented on THRIFT-2495:
----------------------------------------

Github user Jens-G commented on the pull request:

    https://github.com/apache/thrift/pull/107#issuecomment-41503901
  
    Hi,
    
    The problem should already be solved (in a better way, btw) by 
[THRIFT-2495](https://issues.apache.org/jira/browse/THRIFT-2495), so I guess 
that this pull request has become  somewhat obsolete. If not, please reopen 
[THRIFT-2495](https://issues.apache.org/jira/browse/THRIFT-2495) and add a test 
case. 
    
    Appreciating your contribution,
    JensG



> JavaScript/Node string constants lack proper escaping
> -----------------------------------------------------
>
>                 Key: THRIFT-2495
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2495
>             Project: Thrift
>          Issue Type: Bug
>          Components: JavaScript - Compiler, Node.js - Compiler
>    Affects Versions: 0.9
>            Reporter: John Vines
>            Assignee: Jens Geyer
>             Fix For: 0.9.2
>
>         Attachments: test.thrift, thrift-2495-js-missing-escaping.patch
>
>
> In my .thrift file, I have an optional field with a default value of "\\". In 
> java generated code it is properly set to "\\", but in the node.js code it 
> results in "\" which results in an error.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to