Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/119#issuecomment-42712665
Great work Pascal!
thanks for adding the required topic:
https://issues.apache.org/jira/browse/THRIFT-2522
could you please
- add the apache license header to the lib/ts/thrift.d.ts file
- close this pull request
- create a new single commit with title *THRIFT-2522 TypeScript extension
for Thrift Compiler*
- create a new pull request with this commit or attach the patch to
THRIFT-2522
thanks
-roger
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---