[GitHub] thrift pull request: THRIFT-2543 Generated enum type in haskell sh...

[watashi]

GitHub user watashi opened a pull request:

    https://github.com/apache/thrift/pull/127

    THRIFT-2543 Generated enum type in haskell should be qualified

    Compile following thrift files
    **a.thrift**
    ```thrift
    enum X {
      A = 1,
      B = 2,
      C = 4,
      D = 8
    }
    ```
    
    **b.thrift**
    ```thrift
    include "a.thrift"
    
    struct B {
      1: a.X x;
      2: i32 y;
    }
    ```
    
    In generated haskell file, we find
    **B_Types.hs**
    ```haskell
    import qualified A_Types
    
    data B = B{f_B_x :: Maybe X,f_B_y :: Maybe Int32} deriving 
(Show,Eq,Typeable)
    ```
    
    It should be
    **B_Types.hs**
    ```haskell
    import qualified A_Types
    
    data B = B{f_B_x :: Maybe A_Types.X,f_B_y :: Maybe Int32} deriving 
(Show,Eq,Typeable)
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/watashi/thrift THRIFT-2543

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #127
    
----
commit 99ffcf8619ff3001c6521c2598e88e6acf8a6d01
Author: Zejun Wu <zejun...@gmail.com>
Date:   2014-05-24T08:30:38Z

    THRIFT-2543 Generated enum type in haskell should be qualified

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---