+1 to pushing this to post 0.9.2 and we circle back and look at it then -Jake
On Tue, Jun 17, 2014 at 9:42 AM, Henrique Mendonça <[email protected]> wrote: > Hi guys, > > So just to clarify, what do you think about replacing the > "contrib/mingw-cross-compile.sh" by the cmake cross compilation in the > documentation like Roger suggested in the ticket? > Anyone against it? Then do we delete the script to avoid redundancy or > leave it? > I'm also ok to first release 0.9.2 and leave it for 1.0 > > To summarise: it's much faster to build, doesn't require reconfiguring the > file tree and can be built out-of-source without touching the file tree at > all. It obviously adds an extra dependency to the cross-platform build > [only] but it's already pre-installed in most platforms or it's very easy > to do so. > > Cheers, > Henrique > > > > On 17 June 2014 13:40, Hudson (JIRA) <[email protected]> wrote: > > > > > [ > > > https://issues.apache.org/jira/browse/THRIFT-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033691#comment-14033691 > > ] > > > > Hudson commented on THRIFT-2571: > > -------------------------------- > > > > SUCCESS: Integrated in Thrift #1185 (See [ > > https://builds.apache.org/job/Thrift/1185/]) > > THRIFT-2571 doc and speed up travis build (henrique: rev > > 55087a49d335db7da23e23d8d8a9368e4e5ae7a6) > > * compiler/cpp/README.md > > * .travis.yml > > > > > > > Simplify cross compilation using CMake > > > -------------------------------------- > > > > > > Key: THRIFT-2571 > > > URL: https://issues.apache.org/jira/browse/THRIFT-2571 > > > Project: Thrift > > > Issue Type: Improvement > > > Components: Compiler (General) > > > Affects Versions: 1.0 > > > Reporter: Pascal Bach > > > Assignee: Henrique Mendonça > > > Priority: Minor > > > > > > Using CMake would simplify cross compilation. > > > The for example the same build script can be used to build: > > > - Native for Linux using GCC > > > - Native for Windows using Visual Studio > > > - Cross compile for ARM on Linux > > > - Cross compile for Windows form Linux using mingw32 > > > It also makes it easy to generate project files for Eclipse or Visual > > Studio. > > > h2. Some examples: > > > {code:title=Create an eclipse project|borderStyle=solid} > > > mkdir build_ec && cd build_ec > > > cmake -G "Eclipse CDT4 - Unix Makefiles" ../compiler/cpp > > > make > > > {code} > > > Now open the folder build_ec using eclipse. > > > {code:title=Create a Visual Studio project (Windows > > only)|borderStyle=solid} > > > mkdir build_vs && cd build_vs > > > cmake -G "Visual Studio 12" ../compiler/cpp > > > {code} > > > Now open the folder build_vs using Visual Studio. > > > {code:title=Cross compile using mingw32|borderStyle=solid} > > > mkdir build_mingw32 && cd build_mingw32 > > > cmake -DCMAKE_TOOLCHAIN_FILE=../contrib/mingw32-toolchain.cmake > > ../compiler/cpp > > > make > > > {code} > > > > > > > > -- > > This message was sent by Atlassian JIRA > > (v6.2#6252) > > >
