[ 
https://issues.apache.org/jira/browse/THRIFT-2296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Vogt updated THRIFT-2296:
--------------------------------

    Attachment: 021_base_service_rest_140619v1.patch
                020_base_service_140619v2.patch

This updates the "base class for services" patch. 

changes:

-  id string is removed

But it turns out that this is not a good idea. 
I used the id to announce the services at a "broker" server.

And now the names look like 13ShmServer, which is the
mangled name. So I think that the servicename would be
a nice information in the base class. Additionally the 
base class has a "role", which is a hint what the implementation
can handle, so the broker sees that client X is connected to service Y.

So I think, having the servicename in the base class would be
useful.

> Add C++ Base class for service
> ------------------------------
>
>                 Key: THRIFT-2296
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2296
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Compiler
>            Reporter: Martin Vogt
>            Priority: Minor
>         Attachments: 020_base_service_140126v1.patch, 
> 020_base_service_140303v6.patch, 020_base_service_140619v2.patch, 
> 021_base_service_rest_140619v1.patch
>
>
> This patch adds the possibilty to have a common base class
> for a service.
> It's against the TBase patch:
> https://issues.apache.org/jira/browse/THRIFT-1712



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to