[jira] [Created] (THRIFT-2584) Error handler not listened on javascript client

[David Poulailleau (JIRA)]

David Poulailleau created THRIFT-2584:
-----------------------------------------

             Summary: Error handler not listened on javascript client
                 Key: THRIFT-2584
                 URL: https://issues.apache.org/jira/browse/THRIFT-2584
             Project: Thrift
          Issue Type: Bug
          Components: JavaScript - Library
    Affects Versions: 0.9.1, 0.9.2
            Reporter: David Poulailleau


jQuery's error are not handled in the ajax call. This causes the callback not 
to be called when an error happened during a server call.
In library, the ajax call looks like this :
var jqXHR = jQuery.ajax({
            url: this.url,
            data: postData,
            type: 'POST',
            cache: false,
            contentType: 'application/json',
            dataType: 'text thrift',
            converters: {
                'text thrift' : function(responseData) {
                    thriftTransport.setRecvBuffer(responseData);
                    var value = recv_method.call(client);
                    return value;
                }
            },
            context: client,
            success: jQuery.makeArray(args).pop()
        });

Setting object should have an error key, something like this :

var jqXHR = jQuery.ajax({
            url: this.url,
            data: postData,
            type: 'POST',
            cache: false,
            contentType: 'application/json',
            dataType: 'text thrift',
            converters: {
                'text thrift' : function(responseData) {
                    thriftTransport.setRecvBuffer(responseData);
                    var value = recv_method.call(client);
                    return value;
                }
            },
            context: client,
            success: jQuery.makeArray(args).pop(),
            error: jQuery.makeArray(args).pop()
        });



--
This message was sent by Atlassian JIRA
(v6.2#6252)