[
https://issues.apache.org/jira/browse/THRIFT-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14041892#comment-14041892
]
Henrique Mendonça commented on THRIFT-1712:
-------------------------------------------
Hi Martin,
Thanks for your patches! Contribution is what we need, but please try to add at
least one test case on each patch and for each variant you are proposing. It'll
make it much easier to understand, test and commit it, and make sure nobody
breaks your code accidentally in the future.
I like the idea here, but I personally won't have time enough to test the whole
think very soon, hopefully someone has...
Anyway, keep the good work! :)
Cheers,
Henrique
> Add TBase class for c++
> -----------------------
>
> Key: THRIFT-1712
> URL: https://issues.apache.org/jira/browse/THRIFT-1712
> Project: Thrift
> Issue Type: New Feature
> Components: C++ - Compiler
> Affects Versions: 0.8
> Reporter: Martin Vogt
> Assignee: Ben Craig
> Priority: Minor
> Labels: base, c++, class
> Attachments: 010_base_struct_gen_140619v3.patch,
> 011_base_struct_rest_140619v2.patch
>
>
> The generated c++ classes for struct's do not have a common base class.
> The patch adds a "base_struct" option to the compiler:
> - thrift --gen cpp:base_struct
> this will use a TBaseStruct in the thrift installation.
> Another option allows to replace the baseclass with an arbitrary one:
> -thrift --gen cpp:base_struct=MyBase,base_struct_inc=\\</path/MyBase.h\\>\n"
> With this it's possible to extend the TBaseStruct class in the thrift
> installation.
> I like to use this TBase class in QT, as a signal, for example:
> {quote}
> signals:
> void update(const TBase& tBase);
> {quote}
> And in the receiver slot I then can check which kind of message was send:
> {quote}
> // compare static pointers
> if (tBase.ascii_fingerprint == User::ascii_fingerprint) \{
> User* user=(User*)&tBase;
> processUserMessage(user);
> \}
> {quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
