[
https://issues.apache.org/jira/browse/THRIFT-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-2595.
---------------------------------
Resolution: Fixed
Assignee: Wade Simmons
Thanks Wade!
committed
;-r
> Node.js: Fix global leaks and copy-paste errors
> -----------------------------------------------
>
> Key: THRIFT-2595
> URL: https://issues.apache.org/jira/browse/THRIFT-2595
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Affects Versions: 0.9.1
> Reporter: Wade Simmons
> Assignee: Wade Simmons
> Attachments: 0001-fix-global-leaks-and-copy-paste-errors.patch
>
>
> - TCompactProtocol.prototype.writeBool not referencing `booleanField_`
> on `this` correctly. Also using `NULL` instead of `null`.
> - TCompactProtocol.prototype.writeVarint64 had a typo for TProtocolException
> - TCompactProtocol.prototype.readMapBegin had a typo between `kvtype` and
> `kvType`
> - createMultiplexServer leaked a global var `processStatus`
> - TFramedTransport had a line that was accidently copy pasted, leading
> to a global leak of `frameLeft`. (I created the patch the introduced
> this copy paste error in Thrift-1353, so I can confirm it was
> a mistake).
> - createWebServer tried to check a non-existent var `route` and leaked
> a global `result`
--
This message was sent by Atlassian JIRA
(v6.2#6252)
