[
https://issues.apache.org/jira/browse/THRIFT-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053090#comment-14053090
]
Roger Meier commented on THRIFT-2578:
-------------------------------------
Hi Chamila
please take care on whitespace issues.
$ wget https://github.com/apache/thrift/pull/152.patch
$ git apply 152.patch
152.patch:29: trailing whitespace.
152.patch:40: trailing whitespace.
152.patch:153: trailing whitespace.
152.patch:179: trailing whitespace.
serverproc = subprocess.Popen(server_args, stdout=server_log,
stderr=server_log)
152.patch:188: trailing whitespace.
def target():
warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.
please try to cleanup always before you submit
thanks
-roger
> Moving 'make cross' from test.sh to test.py
> -------------------------------------------
>
> Key: THRIFT-2578
> URL: https://issues.apache.org/jira/browse/THRIFT-2578
> Project: Thrift
> Issue Type: Sub-task
> Components: Test Suite
> Reporter: Chamila Dilshan Wijayarathna
> Assignee: Roger Meier
> Labels: gsoc2014
> Attachments:
> 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch,
> 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch,
> 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch,
> 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch,
> 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch,
> 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch
>
>
> Since test.sh has too much redundant code, we are planning to move cross
> language test suite to test.py. By moving this, other than removing
> redundancy we expect to achieve following.
> seperate file to define the tests for server and clients
> cross platform (=> become able to run it on windows)
> remove limitations of scripting language.
> [~roger.meier] has added a initial version of this. Following are yet to do.
> reporting page
> log files
> add languages
> run on windows
--
This message was sent by Atlassian JIRA
(v6.2#6252)
